Clarify mutation is allowed in high-scores#1195
Merged
SleeplessByte merged 2 commits intoexercism:masterfrom Aug 5, 2019
Merged
Clarify mutation is allowed in high-scores#1195SleeplessByte merged 2 commits intoexercism:masterfrom
SleeplessByte merged 2 commits intoexercism:masterfrom
Conversation
Adding a test to check against mutating the list has been suggested and rejected because this is an introductory core exercise and immutability has not yet been introduced. However, all of the reasonable examples provided do not mutate the list so it is not clear to new mentors whether preserving the original list is required when deciding if they should accept a solution.
yawpitch
requested changes
Jul 30, 2019
Contributor
yawpitch
left a comment
yawpitch
left a comment
There was a problem hiding this comment.
I feel like this note is a bit out of place without an example of the "reasonable and acceptable" solution that uses mutation.
Contributor
Author
I was trying to keep it succinct but I see your point. I added examples of the most common mutations I've seen in two of the functions. |
yawpitch
approved these changes
Aug 1, 2019
Contributor
yawpitch
left a comment
yawpitch
left a comment
There was a problem hiding this comment.
Good, with the examples I think this is ready to merge.
This was referenced Aug 3, 2019
cmccandless
approved these changes
Aug 3, 2019
Contributor
|
@adamzev thanks for your work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a test to check against mutating the list has been suggested and rejected because this is an introductory core exercise and immutability has not yet been introduced. However, all of the reasonable examples provided do not mutate the list so it is not clear to new mentors whether preserving the original list is required when deciding if they should accept a solution. I added clarification to the notes that mutating is acceptable but should be commented on.
See this thread for further discussion that led to this pull request.